Skip to content

Support Elixir ~> 1.12 - #478

Merged
whatyouhide merged 4 commits into
mainfrom
ericmj/support-elixir-1.12
Apr 23, 2026
Merged

whatyouhide merged 4 commits into
mainfrom
ericmj/support-elixir-1.12

Conversation

@ericmj

@ericmj ericmj commented Apr 11, 2026

Copy link
Copy Markdown
Member

Replace pinned variables in binary pattern sizes (^var) with erlang.split_binary/2 to support both Elixir 1.12+ and 1.20+ without warnings.

Need this to vendor Mint into Hex.

@coveralls

coveralls commented Apr 11, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 0

Coverage increased (+0.009%) to 87.645%

Details

  • Coverage increased (+0.009%) from the base build.
  • Patch coverage: 9 of 9 lines across 4 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1465
Covered Lines: 1284
Line Coverage: 87.65%
Coverage Strength: 254.73 hits per line

💛 - Coveralls

@ericmj
ericmj requested a review from whatyouhide April 11, 2026 10:32
@ericmj
ericmj marked this pull request as ready for review April 11, 2026 17:20
ericmj added 4 commits April 16, 2026 10:27
Replace pinned variables in binary pattern sizes (^var) with
:erlang.split_binary/2 to support both Elixir 1.12+ and 1.20+
without warnings.
persistent_term has been available since OTP 21.2 and Mint requires
Elixir ~> 1.12 which needs OTP 22+, so it is always available. Remove
the runtime check, the application env, and the empty supervisor.
@ericmj
ericmj force-pushed the ericmj/support-elixir-1.12 branch from f7f0313 to a8823ef Compare April 16, 2026 17:27

@whatyouhide whatyouhide left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@whatyouhide
whatyouhide merged commit 1a82c1d into main Apr 23, 2026
3 checks passed
@whatyouhide
whatyouhide deleted the ericmj/support-elixir-1.12 branch April 23, 2026 16:29
ericmj added a commit to hexpm/hex that referenced this pull request Oct 5, 2026
All four Mint changes Hex depended on are released upstream
(elixir-mint/mint#478, #479, #480 and #481), so vendor from Mint main
(fb850d3, v1.11.0) instead of the integration branch and drop the list
of pending patches from scripts/vendor_mint.sh. Mint.Application no
longer exists upstream, so the skip list for it is gone too.

Mint v1.11.0 reads `:proxy_headers` from the top-level connect options
and only uses the `:proxy` tuple's options for the connection to the
proxy (elixir-mint/mint#494), so Hex.HTTP now passes the
proxy-authorization header there.
ericmj added a commit to hexpm/hex that referenced this pull request Oct 6, 2026
All four Mint changes Hex depended on are released upstream
(elixir-mint/mint#478, #479, #480 and #481), so vendor from Mint main
(fb850d3, v1.11.0) instead of the integration branch and drop the list
of pending patches from scripts/vendor_mint.sh. Mint.Application no
longer exists upstream, so the skip list for it is gone too.

Mint v1.11.0 reads `:proxy_headers` from the top-level connect options
and only uses the `:proxy` tuple's options for the connection to the
proxy (elixir-mint/mint#494), so Hex.HTTP now passes the
proxy-authorization header there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants